Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle Snyk API rate limit #86

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: handle Snyk API rate limit #86

wants to merge 1 commit into from
+115 −10

Conversation

mcombuechen
Copy link
Collaborator

When enriching a particularly large SBOM with Snyk vulnerabilities, the excessive amount of requests can trigger 429 Too Many Requests responses.

This introduces a retry mechanism to account for such a case and honor the retry-after value coming from the Snyk API.

Closes #83.

@mcombuechen mcombuechen requested review from garethr and a team as code owners November 21, 2024 14:25
@mcombuechen mcombuechen marked this pull request as draft November 21, 2024 20:33
@mcombuechen
Copy link
Collaborator Author

Unit tests now failing due to nature of github.com/jarcoal/httpmock, investigating whether this can easily be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethr garethr Awaiting requested review from garethr garethr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retries when hitting rate limits
1 participant
@mcombuechen