Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved error messages around network requests #5621

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: improved error messages around network requests #5621

merged 1 commit into from
Dec 10, 2024

Conversation

CatalinSnyk
Copy link
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

@CatalinSnyk CatalinSnyk requested a review from a team as a code owner December 9, 2024 15:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code.spec.ts

Generated by 🚫 dangerJS against f6fc5f7

@CatalinSnyk CatalinSnyk force-pushed the feat/meaningful-auth-errors-CLI-575_2 branch from 2fb601f to 9b21808 Compare December 9, 2024 16:33
@PeterSchafer
Copy link
Collaborator

LGTM! But please squash your commits

@CatalinSnyk CatalinSnyk force-pushed the feat/meaningful-auth-errors-CLI-575_2 branch from aa192fb to f6fc5f7 Compare December 10, 2024 13:18
@CatalinSnyk CatalinSnyk merged commit 888315d into main Dec 10, 2024
7 checks passed
@CatalinSnyk CatalinSnyk deleted the feat/meaningful-auth-errors-CLI-575_2 branch December 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CatalinSnyk @PeterSchafer