ページ解析系スクリプトをcontentスクリプトから分離してモジュール化したい #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
放置し過ぎて何したかよく覚えてなかったので、ボットが色々やってくれたやつにrebaseして、MR作ってdiff眺めてる… 🙈 |
Closed
- add initializer/head - remove console.log... (´ - ω - ｀)
snowsunny
force-pushed
the
modularize_page_analysis
branch
from
7b0b2fe to
32a62a5
Compare
snowsunny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
何でこのPRが必要なの？ 🤔
色んなサービスに対応する為に、contentスクリプトにハードコードされていたページ解析系スクリプトをモジュール化したかったから
Issue: #1
やった事は何？ 📝
確認した事は何？ ✔️
ざっくりとした動作確認。多分大丈夫だと思う。(´・ω・｀)
感想 ❤️
#14 を進めたいけど、本当どうするのが良いのか…(´ - ω - ｀)