Kinesis allow larger batches when sqs buffer is enabled #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Content-Type` was not explicitly returned for POST requests. This would result in errors being logged for javascript tracker in Firefox[1]. Now, the behavior is rolled back to previous where collector would return `Content-Type` header for these requests. Addresses [BCPF-1102] and [PDP-1110] --- 1 - https://bugzilla.mozilla.org/show_bug.cgi?id=884693
The goal of the feature was to prevent long body reads in GCP, this however does not prevent the slow incoming connection handling at the framework level. Therefore, as this adds unnecessary complexity with possible negative performance impact, the feature is removed. The configuration parameter is no longer used, but can remain as is.
Currently, healthchecks reside behind the same timeout settings as any other endpoint. We observed that when autoscaling under massive load, it is possible for collector to be taken down because of long health check responses. Which previously did not happen. We therefore move healthchecks above the timeout middleware to return to previous behavior. Additionally, this allows us to set arbitrarily short (or long) response times for the regular endpoints when necessary. --- Part of [PDP-1408].
The reference defaults should be less strict and match the settings we define upstream.
Previously, we would return 503 Service Unavailable, suggesting that failures should not be retried and leading to confusion with early timeout being hit. Now, we return 408 Request Timeout which is more explicit and easier to monitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.