Set serverAnonymisation more quickly #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplow-tracker/src/main/java/com/snowplowanalytics/core/emitter/Emitter.kt
Outdated
Show resolved
Hide resolved
mscwilson
force-pushed
the
bug/688-delayed_serveranon_header
branch
from
b8369fe to
8971c5e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #688
Currently, when
serverAnonymisationis set in theEmitter, the wholeOkHttpNetworkConnectionis recreated. This is slow, so there can be a delay in setting the anonymisingSP-Anonymousheader.This change sets the
serverAnonymisationdirectly inOkHttpNetworkConnection. Now the opposite is true - some events tracked just before the flag was set can end up with theSP-Anonymousheader if they're still being processed when the change is made.NB: the CI tests for API 30 are currently failing due to flakiness. This is a known problem and will be addressed in a future PR.