Undeprecate PageView event #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matus-tomlein
approved these changes
Jan 26, 2024
| @@ -18,9 +18,7 @@ import com.snowplowanalytics.core.constants.TrackerConstants | |||
| /** | |||
| * A pageView event. | |||
| * @param pageUrl The page URL. | |||
| * @Deprecated This event has been designed for web trackers, and is not suitable for mobile apps. | |||
There was a problem hiding this comment.
Maybe we can keep the comment? We do have a comment like that on the iOS tracker and it is true that page views are not suitable for mobile apps (disregarding web views), so might be a relevant info to guide users away from this in case they want standard mobile tracking? Android Studio doesn't seem to do anything about the comment.
There was a problem hiding this comment.
I'll move the comment to the main part of the docstring, instead of using the Deprecated annotation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PageViewevent class was accidentally marked as deprecated during the migration to Kotlin for v5. This change reverses that.