Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct 'repository' references in bad rows schemas #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miike
Copy link
Contributor

@miike miike commented Feb 15, 2021

There's a spelling error in a few of the bad rows schemas - the error exists in the schemas themselves but the upstream components have the correct spelling.

I'm not sure this is the best way to correct - by overriding the schema or if it's better to just go with a new model version for each of the schemas, though this would then result in having to update both the upstream and downstream dependencies.

For downstream dependencies I don't think there's many but https://github.com/snowplow-incubator/snowplow-badrows will be one of them.

cc @chuwy @benjben

@chuwy
Copy link
Contributor

chuwy commented Mar 10, 2021

Oh, good catch, @miike.

So this part of JSON comes from Iglu Client https://github.com/snowplow/iglu-scala-client/blob/379c433048a9899fb55e8f9151f3c85b91cc927b/src/main/scala/com.snowplowanalytics.iglu/client/ClientError.scala#L53

It's also strange because in snowplow-badrows we have property-based testing checking that any generated BadRow is always valid against corresponding JSON schema. I need to investigate why we didn't catch this.

@chuwy chuwy closed this Mar 10, 2021
@chuwy chuwy reopened this Mar 10, 2021
@chuwy chuwy added this to the Release 122 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants