Allow for delay in Writer discovering new columns #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the loader alters the table to add new columns, it immediately opens a new Writer and expects the Writer to be aware of the new columns. However, we have found the Writer might get opened with no awareness of the newly added columns. Presumbably because of the async nature of BigQuery's architecture. This fix works by retrying opening the writer until eventually it should get opened with awareness of the new columns
pondzix
approved these changes
May 7, 2024
When schema evolves, e.g. when new nested field is added to entity, loader should explicity try to alter underlying BigQuery schema. It works correctly for self-describing events (unstruct columns), but as it turns in case of contexts it doesn't modify schema, alter is skipped, what results in bad data. This commit should fix this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the loader alters the table to add new columns, it immediately opens a new Writer and expects the Writer to be aware of the new columns. However, we have found the Writer might get opened with no awareness of the newly added columns. Presumbably because of the async nature of BigQuery's architecture.
This fix works by retrying opening the writer until eventually it should get opened with awareness of the new columns