Stay healthy if BigQuery table exceeds column limit #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
force-pushed
the
handle-exceed-column-limit
branch
5 times, most recently
from
d4fe3d3
to
ca4c710
Compare
istreeter
force-pushed
the
handle-exceed-column-limit
branch
from
ca4c710
to
8642aaf
Compare
pondzix
reviewed
Apr 2, 2024
...s/core/src/main/scala/com.snowplowanalytics.snowplow.bigquery/processing/BigQueryUtils.scala
Outdated
Show resolved
Hide resolved
...es/core/src/main/scala/com.snowplowanalytics.snowplow.bigquery/processing/TableManager.scala
Show resolved
Hide resolved
...es/core/src/main/scala/com.snowplowanalytics.snowplow.bigquery/processing/TableManager.scala
Outdated
Show resolved
Hide resolved
istreeter
force-pushed
the
handle-exceed-column-limit
branch
from
289e85f
to
85e0f07
Compare
pondzix
reviewed
Apr 2, 2024
...es/core/src/main/scala/com.snowplowanalytics.snowplow.bigquery/processing/TableManager.scala
Show resolved
Hide resolved
...es/core/src/main/scala/com.snowplowanalytics.snowplow.bigquery/processing/TableManager.scala
Outdated
Show resolved
Hide resolved
pondzix
approved these changes
Apr 4, 2024
istreeter
force-pushed
the
handle-exceed-column-limit
branch
from
a5ee852
to
312a2a5
Compare
istreeter
added a commit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With BigQuery Loader v1, we have previously hit problems when the number of columns in the table gets close to 10000. This is much less likely with Loader v2, but even so we should handle that situation elegantly.
After this commit, we will catch and handle the known exception when the table exceeds the maximum number of columns. After receiving that exception once, the loader should stay healthy and not make any further attempt to alter the table. Any event should go to the bad topic, if it cannot fit into the un-altered table.