Manage Writer resource to be consistent with Snowflake Loader #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
approved these changes
Feb 14, 2024
| import WriterProviderSpec._ | ||
|
|
||
| def is = s2""" | ||
| The channel provider should |
BigQuery Loader (v2 branch) and Snowflake Loader are similar applications, in that they both open a channel to the warehouse which must be closed / re-opened whenever the table is altered. This commit brings to the BigQuery loader all the nice patterns that we figured out in the Snowflake Loader. - A Writer[F] is a trait with a single method write, which writes events into the warehouse - A Writer.Builder[F] is a trait with a single method open, which opens a Writer. - A concrete implementation of Writer.Builder[F] is provided as a wrapper around the BigQuery SDK's Writer - The Environment class holds a Coldswap[F, Writer[F]], wherein the ColdSwap has methods for opening / closing the Writer. - The Coldswap[F, Writer[F]] is initialized as a wrapper around any Writer.Builder[F]. - A WriterProviderSpec has the unit tests to validate the implementation of Coldswap[F, Writer[F]]
istreeter
force-pushed
the
channel-provider
branch
from
7d2887c
to
79b94dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery Loader (v2 branch) and Snowflake Loader are similar applications, in that they both open a channel to the warehouse which must be closed / re-opened whenever the table is altered.
This commit brings to the BigQuery loader all the nice patterns that we figured out in the Snowflake Loader.