Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GCP user agent header for BQ and Pubsub #363

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Set GCP user agent header for BQ and Pubsub #363

merged 1 commit into from
Nov 16, 2023

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Nov 15, 2023 •
edited
Loading

Header value configurable with:

{
  "projectId": "..."
   ...

  "gcpUserAgent": {
      "productName": "Snowplow OSS"
  }
}

option

spenes
spenes approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@spenes spenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pondzix pondzix merged commit 8f58ce3 into develop Nov 16, 2023
1 check passed
@istreeter istreeter deleted the feature/set_user_agent branch April 10, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenes spenes spenes approved these changes

@istreeter istreeter istreeter approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pondzix @istreeter @spenes @snowplowcla