Support trailing comments in passed SQL queries #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support trailing comments, particularly the inline types with -- or //, the query wrapping performed
in the connector needs to ensure the query is placed into a new line of its own
Otherwise, passing such an inline comment will break the Snowflake SQL syntax.
Attempting any of the following, for example, fails today:
The failure occurs due to Spark wrapping around the query and executing a resulting invalid syntax:
The change made here works by adjusting such wrapping to always, safely place provided statements into their own line:
This allows for a valid syntax to be used despite users accidentally placing trailing comments at the end.
The tests added fail without the fixes added (tested via
sbt test it:test
).