Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOSNOW | AST/unparser: fixed the script to ensure the output directory exists before scping the JAR #2931

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

sfc-gh-azwiegincew
Copy link
Collaborator

@sfc-gh-azwiegincew sfc-gh-azwiegincew commented Jan 24, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes NOSNOW

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Just an internal script change... No impact on anything in prod.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-server Server-side snowpark work labels Jan 24, 2025
@sfc-gh-azwiegincew sfc-gh-azwiegincew enabled auto-merge (squash) January 24, 2025 19:34
@sfc-gh-azwiegincew sfc-gh-azwiegincew merged commit c6d83b8 into main Jan 24, 2025
35 of 37 checks passed
@sfc-gh-azwiegincew sfc-gh-azwiegincew deleted the azwiegincew/fix-copy-script branch January 24, 2025 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-server Server-side snowpark work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants