SNOW-1878542: Enable python 3.12 #2852
Merged
+83
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for handling this! Here's some changes you might need too: #2641 |
sfc-gh-jrose
added
the
NO-CHANGELOG-UPDATES
sfc-gh-jrose
force-pushed
the
jrose_snow_1878542_python_3_12
branch
from
6117933 to
9c275df
Compare
sfc-gh-jrose
commented
Jan 14, 2025
Comment on lines
+4276
to
+4279
| df = session.create_dataframe( | ||
| [["xyz", int("1" * 19)] for _ in range(200000)], schema=["a1", "b1"] | ||
| ) | ||
| else: |
There was a problem hiding this comment.
This create statement was causing timeouts in live-mode tests. When running in live it will generate the data server side instead which seems more stable.
sfc-gh-jrose
commented
Jan 14, 2025
| t0 = time() | ||
| async_job = session.sql("select system$wait(3)").collect_nowait() |
There was a problem hiding this comment.
3.12 was about a tenth of a second faster which broke the assert in this test. moving the start time to before the collect is start fixes this issue.
sfc-gh-jrose
requested review from
sfc-gh-jkew,
sfc-gh-helmeleegy,
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-aalam
sfc-gh-aalam
approved these changes
Jan 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1878542
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds python 3.12 to our support matrix. The 3.12 test suite has been enabled for all OSs and CSPs in order to fully check compatibility. Once we've cut a release with 3.12 we should narrow the test matrix and enable the udf tests for 3.12.