Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1754978]: Add support for first and last in GroupBy.agg #2847

Merged
merged 14 commits into from
Jan 16, 2025
Merged

[SNOW-1754978]: Add support for first and last in GroupBy.agg #2847

merged 14 commits into from
Jan 16, 2025

Conversation

sfc-gh-rdurrani
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani commented Jan 9, 2025 •
edited by sfc-gh-helmeleegy
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1754978

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Adds support for first and last in groupby.agg (when used with other functions)

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner January 9, 2025 23:32
sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but LGTM otherwise. Thanks for pushing this through!

src/snowflake/snowpark/modin/plugin/_internal/aggregation_utils.py Outdated Show resolved Hide resolved
@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) January 9, 2025 23:47
sfc-gh-joshi
sfc-gh-joshi approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

src/snowflake/snowpark/modin/plugin/_internal/aggregation_utils.py Show resolved Hide resolved
sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Jan 10, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-rdurrani sfc-gh-rdurrani changed the title [SNOW-1754978]: Add support for first and last in GroupBy.apply [SNOW-1754978]: Add support for first and last in GroupBy.agg Jan 10, 2025
@sfc-gh-helmeleegy
Copy link
Contributor

LGTM, thanks!

@sfc-gh-joshi sfc-gh-joshi disabled auto-merge January 16, 2025 22:26
@sfc-gh-joshi sfc-gh-joshi merged commit eea9995 into main Jan 16, 2025
54 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the rdurrani-SNOW-1754978 branch January 16, 2025 22:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-rdurrani @sfc-gh-helmeleegy @sfc-gh-nkrishna @sfc-gh-joshi