Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCT-7635 Create a wrapper for the is_null function. #70

Merged
merged 2 commits into from
Dec 4, 2023
Merged

SCT-7635 Create a wrapper for the is_null function. #70

merged 2 commits into from
Dec 4, 2023

Conversation

sfc-gh-dchaconbarrantes
Copy link
Contributor

@sfc-gh-dchaconbarrantes sfc-gh-dchaconbarrantes commented Nov 30, 2023 •
edited by jira bot
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes: SCT-7635

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    In ApacheSpark the function is called isNull because in Scala the snake_case notation is not the standard one. By generating this wrapper both sides are going to have the same name(SparkApache and Snowpark API)

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-bli
sfc-gh-bli approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dchaconbarrantes sfc-gh-dchaconbarrantes merged commit 688221e into main Dec 4, 2023
13 checks passed
@sfc-gh-dchaconbarrantes sfc-gh-dchaconbarrantes deleted the SCT-7635 branch December 4, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dchaconbarrantes @sfc-gh-bli