SNOW-1820719 Refactor Session.sql Function #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bli
commented
Nov 21, 2024
| @@ -65,7 +65,7 @@ public static SessionBuilder builder() { | |||
| * @since 0.8.0 | |||
| */ | |||
| public DataFrame sql(String query) { | |||
| return new DataFrame(session.sql(query, JavaUtils.objectArrayToSeq(new Object[0]))); | |||
| return new DataFrame(session.sql(query)); | |||
There was a problem hiding this comment.
This change guarantees Java code can invoke Session.sql function without parameter. So no additional test is required.
sfc-gh-bli
added a commit
that referenced
this pull request
Nov 22, 2024
* refactor session sql * fix java api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a regression in the release tests. It is a legacy issue, Java Sproc can invoke Scala session. However, when Java code invokes Scala functions, the default value of function arguments will be ignored. Therefore, the new change in the
Session.sqlwill break all existing code related this function.This PR refactor the
Session.sqlfunction to split it to two functions, with and without parameters. Then the new API will not impact any existing code.