Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIT-2214] Add support for com.snowflake.snowpark.Row.getAs(String) #166

Merged

Conversation

sfc-gh-lfallasavendano
Copy link
Contributor

@sfc-gh-lfallasavendano sfc-gh-lfallasavendano commented Sep 26, 2024

Adds an implementation for the Row.getAs(String) for retreving values from a Row using field name.

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SIT-2214

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

Adds an implementation for the `Row.getAs(String)` for retreving values
from a `Row` using field name.
Copy link
Collaborator

@sfc-gh-lbravozuniga sfc-gh-lbravozuniga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-lfallasavendano sfc-gh-lfallasavendano merged commit e57e78a into main Oct 7, 2024
16 checks passed
@sfc-gh-lfallasavendano sfc-gh-lfallasavendano deleted the lfallasavendano-SIT-2214-row-getas-string branch October 7, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants