Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIT-2192 Add a new overload for com.snowflake.snowpark.functions.round function #150

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

sfc-gh-fgonzalezmendez
Copy link
Collaborator

@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez commented Aug 23, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SIT-2192

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    It adds a new overload for the function com.snowflake.snowpark.functions.round that allows to indicate the scale as an integer value. Also, it improves the code documentation for the other overloads of this function.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez merged commit 9313150 into main Aug 29, 2024
16 checks passed
@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez deleted the SIT-2192 branch August 29, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants