Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 802269 add log10, log1p, base64 and unbase64 functions #143

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

sfc-gh-gmahadevan
Copy link
Collaborator

@sfc-gh-gmahadevan sfc-gh-gmahadevan commented Aug 14, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #802269

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Add log10 and log1p functions for scala and java which takes column name as both ColumnType and StringType

API Description
function.log10 Computes the logarithm of the given column in base 10
functions.log1p Computes the natural logarithm of the given value plus one
functions.base64 Computes the BASE64 encoding of a column and returns it as a string column.
functions.unbase64 Decodes a BASE64 encoded string column and returns it as a column.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-gmahadevan sfc-gh-gmahadevan changed the title Snow 802269 add log10 and log1p functions Snow 802269 add log10, log1p, base64 and unbase64 functions Aug 15, 2024
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-gmahadevan sfc-gh-gmahadevan merged commit 833ef6d into main Aug 15, 2024
16 checks passed
@sfc-gh-gmahadevan sfc-gh-gmahadevan deleted the snow-802269-func3-gm branch August 15, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants