Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1480787 Fix DataFrameSuite test to validate with pivot v1 and pivot v2 #128

Merged
merged 2 commits into from
Jul 30, 2024
Merged

SNOW-1480787 Fix DataFrameSuite test to validate with pivot v1 and pivot v2 #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302895d
SNOW-1480787 Fix DataFrameSuite test to validate with pivot v1 and pi…
sfc-gh-evandenberg Jul 29, 2024
30760fe
Update
sfc-gh-evandenberg Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions src/test/scala/com/snowflake/snowpark_test/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,9 @@ trait DataFrameSuite extends TestData with BeforeAndAfterEach {
assert(double2.stat.approxQuantile(Array[String](), Array[Double]()).isEmpty)
}

test("df.stat.pivot") {
private def testDataframeStatPivot() : Unit = {
assert(
getShowString(monthlySales.stat.crosstab("empid", "month"), 10) ==
getShowString(monthlySales.stat.crosstab("empid", "month").sort(col("empid")), 10) ==
"""---------------------------------------------------
||"EMPID" |"'JAN'" |"'FEB'" |"'MAR'" |"'APR'" |
|---------------------------------------------------
Expand All @@ -481,29 +481,29 @@ trait DataFrameSuite extends TestData with BeforeAndAfterEach {
|""".stripMargin)

assert(
getShowString(monthlySales.stat.crosstab("month", "empid"), 10) ==
getShowString(monthlySales.stat.crosstab("month", "empid").sort(col("month")), 10) ==
"""-------------------------------------------------------------------
||"MONTH" |"CAST(1 AS NUMBER(38,0))" |"CAST(2 AS NUMBER(38,0))" |
|-------------------------------------------------------------------
||JAN |2 |2 |
||APR |2 |2 |
||FEB |2 |2 |
||JAN |2 |2 |
||MAR |2 |2 |
||APR |2 |2 |
|-------------------------------------------------------------------
|""".stripMargin)

assert(
getShowString(date1.stat.crosstab("a", "b"), 10) ==
getShowString(date1.stat.crosstab("a", "b").sort(col("a")), 10) ==
"""----------------------------------------------------------------------
||"A" |"CAST(1 AS NUMBER(38,0))" |"CAST(2 AS NUMBER(38,0))" |
|----------------------------------------------------------------------
||2020-08-01 |1 |0 |
||2010-12-01 |0 |1 |
||2020-08-01 |1 |0 |
|----------------------------------------------------------------------
|""".stripMargin)

assert(
getShowString(date1.stat.crosstab("b", "a"), 10) ==
getShowString(date1.stat.crosstab("b", "a").sort(col("b")), 10) ==
"""-----------------------------------------------------------
||"B" |"TO_DATE('2020-08-01')" |"TO_DATE('2010-12-01')" |
|-----------------------------------------------------------
Expand All @@ -513,17 +513,17 @@ trait DataFrameSuite extends TestData with BeforeAndAfterEach {
|""".stripMargin)

assert(
getShowString(string7.stat.crosstab("a", "b"), 10) ==
getShowString(string7.stat.crosstab("a", "b").sort(col("a")), 10) ==
"""----------------------------------------------------------------
||"A" |"CAST(1 AS NUMBER(38,0))" |"CAST(2 AS NUMBER(38,0))" |
|----------------------------------------------------------------
||str |1 |0 |
||NULL |0 |1 |
||str |1 |0 |
|----------------------------------------------------------------
|""".stripMargin)

assert(
getShowString(string7.stat.crosstab("b", "a"), 10) ==
getShowString(string7.stat.crosstab("b", "a").sort(col("b")), 10) ==
"""--------------------------
||"B" |"'str'" |"NULL" |
|--------------------------
Expand All @@ -533,6 +533,20 @@ trait DataFrameSuite extends TestData with BeforeAndAfterEach {
|""".stripMargin)
}

test("df.stat.pivot") {
testWithAlteredSessionParameter(
testDataframeStatPivot(),
"ENABLE_PIVOT_VIEW_WITH_OBJECT_AGG",
"disable",
skipIfParamNotExist = true)

testWithAlteredSessionParameter(
testDataframeStatPivot(),
"ENABLE_PIVOT_VIEW_WITH_OBJECT_AGG",
"enable",
skipIfParamNotExist = true)
}

test("df.stat.sampleBy") {
assert(
getShowString(monthlySales.stat.sampleBy(col("empid"), Map(1 -> 0.0, 2 -> 1.0)), 10) ==
Expand Down
Loading