Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1551862 Don't Report Error in UpdateResult when ERROR_ON_NONDETERMINISTIC_UPDATE=true #126

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

sfc-gh-bli
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-bli sfc-gh-bli requested a review from sfc-gh-yuwang July 26, 2024 17:34
@sfc-gh-bli sfc-gh-bli enabled auto-merge (squash) July 30, 2024 17:36
@sfc-gh-bli sfc-gh-bli merged commit 1b6f518 into main Jul 30, 2024
15 checks passed
@sfc-gh-bli sfc-gh-bli deleted the snow-1551862 branch July 30, 2024 18:38
sfc-gh-bli added a commit that referenced this pull request Aug 5, 2024
…RMINISTIC_UPDATE=true (#126)

* fix merge

* fix update result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants