SNOW-1480779 Support Method Chain in the Telemetry #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,39 +14,39 @@ public class JavaOpenTelemetrySuite extends JavaOpenTelemetryEnabled { | |||
| public void cacheResult() { | |||
| DataFrame df = getSession().sql("select * from values(1),(2),(3) as t(num)"); | |||
| df.cacheResult(); | |||
| checkSpan("snow.snowpark.DataFrame", "cacheResult", null); | |||
| checkSpan("snow.snowpark.DataFrame", "cacheResult"); | |||
There was a problem hiding this comment.
Do we not check method chain in this situation?
There was a problem hiding this comment.
Yes, I improved this checker function.
private void checkSpan(String className, String funcName) {
StackTraceElement[] stack = Thread.currentThread().getStackTrace();
StackTraceElement file = stack[2];
checkSpan(
className,
funcName,
"JavaOpenTelemetrySuite.java",
file.getLineNumber() - 1,
"DataFrame." + funcName);
}if no methodChain input, the default one is "DataFrame." + funcName.
sfc-gh-yuwang
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Method Chain in the Open Telemetry