Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIT-1627: Set the app name in the session query tag in JSON format #116

Merged
merged 1 commit into from
Jul 2, 2024
Merged

SIT-1627: Set the app name in the session query tag in JSON format #116

merged 1 commit into from
Jul 2, 2024

Conversation

sfc-gh-fgonzalezmendez
Copy link
Collaborator

@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez commented Jul 1, 2024 •
edited by jira bot
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SIT-1627

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    When a new session is created, the app name will be set to the session query tag in JSON format instead of the key=value format used in previous versions. The goal of this change is to make the app name compatible with the updateQueryTag function.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-bli
sfc-gh-bli approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez merged commit 6511114 into main Jul 2, 2024
17 checks passed
@sfc-gh-fgonzalezmendez sfc-gh-fgonzalezmendez deleted the SIT-1627 branch July 2, 2024 13:14
@s1ck s1ck mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fgonzalezmendez @sfc-gh-bli