SNOW-1490100 Create Implement OpenTelemetry API and Span Function #113
Conversation
| import io.opentelemetry.sdk.trace.SdkTracerProvider | ||
| import io.opentelemetry.sdk.trace.`export`.SimpleSpanProcessor | ||
|
|
||
| trait OpenTelemetryEnabled extends SNTestBase { |
There was a problem hiding this comment.
Create a new trait for OpenTelemetry related tests.
| <dependency> | ||
| <groupId>io.opentelemetry</groupId> | ||
| <artifactId>opentelemetry-bom</artifactId> | ||
| <version>1.39.0</version> |
There was a problem hiding this comment.
I have a question here: how is the version control of a specific library done in Java? Does this code mean that user have to use opentelemetry-bom==1.39.0? Is there a way to limit it like >1.0.0, <2.0.0?
There was a problem hiding this comment.
When compile, Maven while load opentelemetry 1.39.0 to compile the project. But during runtime, it actually works with any compatible dependencies.
| import com.snowflake.snowpark.DataFrame | ||
| import io.opentelemetry.api.GlobalOpenTelemetry | ||
|
|
||
| object OpenTelemetry extends Logging { |
There was a problem hiding this comment.
One question about how OpenTelemetry trace action function, in Python, our implementation wrap around the action function. I am asking this because we also want to record any exception happened in the span that is not caused by open telemetry, the example to record it is here: https://opentelemetry.io/docs/languages/java/instrumentation/#set-span-status
OpenTelemetry