Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1320314: fix Null handling in Variants #109

Merged
merged 5 commits into from
Jun 4, 2024
Merged

SNOW-1320314: fix Null handling in Variants #109

merged 5 commits into from
Jun 4, 2024

Conversation

sfc-gh-yuwang
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1320314

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-yuwang sfc-gh-yuwang requested a review from sfc-gh-bli May 30, 2024 21:32
sfc-gh-bli
sfc-gh-bli approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small suggestion. Please fix it before merge.

src/main/scala/com/snowflake/snowpark/types/Variant.scala Show resolved Hide resolved
@sfc-gh-yuwang sfc-gh-yuwang merged commit 1fa8c6f into main Jun 4, 2024
15 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-1320314 branch June 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-yuwang @sfc-gh-bli