Skip to content

Commit

Permalink
Update comments and rename param
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-aherreraaguilar committed Mar 4, 2024
1 parent 6a75aab commit 120ea73
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
6 changes: 3 additions & 3 deletions src/main/java/com/snowflake/snowpark_java/Functions.java
Original file line number Diff line number Diff line change
Expand Up @@ -377,11 +377,11 @@ public static Column sum(Column col) {
* sum of unique non-null values. If all records inside a group are NULL, the function returns
* NULL.
*
* @since 0.9.0
* @param str The input string
* @since 1.12.0
* @param colName The input column name
* @return The result column
*/
public static Column sum(String str) { return sum(col(str)); }
public static Column sum(String colName) { return sum(col(colName)); }

/**
* Returns the sum of non-NULL distinct records in a group. You can use the DISTINCT keyword to
Expand Down
12 changes: 5 additions & 7 deletions src/main/scala/com/snowflake/snowpark/functions.scala
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,7 @@ object functions {
def stddev_pop(e: Column): Column = builtin("stddev_pop")(e)

/**
* Returns the sum of non-NULL records in a group. You can use the DISTINCT keyword to compute
* the sum of unique non-null values. If all records inside a group are NULL,
* Returns the sum of non-NULL records in a group. If all records inside a group are NULL,
* the function returns NULL.
*
* @group agg_func
Expand All @@ -358,16 +357,15 @@ object functions {
def sum(e: Column): Column = builtin("sum")(e)

/**
* Returns the sum of non-NULL records in a group. You can use the DISTINCT keyword to compute
* the sum of unique non-null values. If all records inside a group are NULL,
* Returns the sum of non-NULL records in a group. If all records inside a group are NULL,
* the function returns NULL.
*
* @group agg_func
* @since 0.1.0
* @param e The input string
* @since 12.1.0
* @param colName The input column name
* @return The result column
*/
def sum(e: String): Column = sum(col(e))
def sum(colName: String): Column = sum(col(colName))

/**
* Returns the sum of non-NULL distinct records in a group. You can use the DISTINCT keyword to
Expand Down

0 comments on commit 120ea73

Please sign in to comment.