-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otel proto codegen forward serialization #42
Merged
sfc-gh-jopel
merged 23 commits into
snowflakedb:main
from
sfc-gh-jopel:add-otel-codegen-forward-serialization
Nov 21, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
67413d1
Forward serialization
sfc-gh-jopel e6882dc
Add workflow
sfc-gh-jopel 757cd33
Cleanup the generator
sfc-gh-jopel 5baec3d
rename marshaler modules
sfc-gh-jopel 8c9ea28
Pin dev and test requirements versions
sfc-gh-jopel 09627ba
match proto embedded message interface, fix enums
sfc-gh-jopel b177786
Fix enum
sfc-gh-jopel 455c5d0
Cleanup varint functions
sfc-gh-jopel 6aba507
Cleanup plugin
sfc-gh-jopel 0bdbcb0
Fix tests
sfc-gh-jopel 1ff8391
cleanup plugin
sfc-gh-jopel 1a8d826
Toggle inline
sfc-gh-jopel 0378493
Inline init
sfc-gh-jopel 05caebb
Cleanup plugin
sfc-gh-jopel a36f504
Feedback
sfc-gh-jopel 8d31aee
Update test
sfc-gh-jopel 4b465c3
Nullable arguments
sfc-gh-jopel b67548b
Remove unused imports
sfc-gh-jopel 8f35616
Add string encode caching
sfc-gh-jopel c5793a2
Remove cache of fields to improve perf
sfc-gh-jopel 335a46b
Revert "Remove cache of fields to improve perf"
sfc-gh-jopel d81938b
Lazily init cache
sfc-gh-jopel 715c3ae
Cleanup unused init stuff
sfc-gh-jopel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# This workflow will delete and regenerate the opentelemetry marshaling code using scripts/proto_codegen.sh. | ||
# If generating the code produces any changes from what is currently checked in, the workflow will fail and prompt the user to regenerate the code. | ||
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
|
||
name: Check Codegen | ||
|
||
on: | ||
push: | ||
branches: [ "main" ] | ||
paths: | ||
- "scripts/**" | ||
- "src/snowflake/telemetry/_internal/opentelemetry/proto/**" | ||
- ".github/workflows/check-codegen.yml" | ||
pull_request: | ||
branches: [ "main" ] | ||
paths: | ||
- "scripts/**" | ||
- "src/snowflake/telemetry/_internal/opentelemetry/proto/**" | ||
- ".github/workflows/check-codegen.yml" | ||
|
||
jobs: | ||
check-codegen: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: "3.11" | ||
- name: Run codegen script | ||
run: | | ||
rm -rf src/snowflake/telemetry/_internal/opentelemetry/proto/ | ||
./scripts/proto_codegen.sh | ||
- name: Check for changes | ||
run: | | ||
git diff --exit-code || { echo "Code generation produced changes! Regenerate the code using ./scripts/proto_codegen.sh"; exit 1; } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Jinja2==3.1.4 | ||
grpcio-tools==1.62.3 | ||
protobuf==4.25.5 | ||
black==24.10.0 | ||
isort==5.13.2 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍