Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1063081 Bump opentelemetry-python dependencies to 1.23.0 #19

Merged
merged 1 commit into from
Mar 21, 2024
Merged

SNOW-1063081 Bump opentelemetry-python dependencies to 1.23.0 #19

merged 1 commit into from
Mar 21, 2024

Conversation

sfc-gh-tmonk
Copy link
Collaborator

This PR:

  • bumps opentelemetry-python dependencies to 1.23.0.
  • adjusts the SnowflakeLoggingHandler implementation to behave the same even with all the changes to opentelemetry-python's between 1.12.0 and 1.23.0

@sfc-gh-tmonk sfc-gh-tmonk requested a review from a team as a code owner March 12, 2024 23:44
@sfc-gh-tmonk sfc-gh-tmonk force-pushed the tmonk-SNOW-1063081-opentelemetry-1-23-0 branch 5 times, most recently from 30bcea7 to 637c592 Compare March 14, 2024 21:42
@sfc-gh-alitouka
Copy link

LGTM for the instrumentation scope patch, but please address Bogdan's comments.

sfc-gh-bdrutu
sfc-gh-bdrutu reviewed Mar 15, 2024
View reviewed changes
tests/test_trace_encoder.py Show resolved Hide resolved
tests/test_metrics_encoder.py Show resolved Hide resolved
tests/test_log_encoder.py Show resolved Hide resolved
@sfc-gh-tmonk sfc-gh-tmonk force-pushed the tmonk-SNOW-1063081-opentelemetry-1-23-0 branch from 637c592 to e488c51 Compare March 19, 2024 06:53
@sfc-gh-tmonk sfc-gh-tmonk force-pushed the tmonk-SNOW-1063081-opentelemetry-1-23-0 branch from e488c51 to 7863a3f Compare March 20, 2024 19:32
@sfc-gh-tmonk sfc-gh-tmonk merged commit 01adb2b into main Mar 21, 2024
4 checks passed
@sfc-gh-tmonk sfc-gh-tmonk deleted the tmonk-SNOW-1063081-opentelemetry-1-23-0 branch March 21, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@sfc-gh-bdrutu sfc-gh-bdrutu sfc-gh-bdrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-tmonk @sfc-gh-alitouka @bogdandrutu @sfc-gh-bdrutu