Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [ and ] to _rfc_1738_quote. #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JDarDagran
Copy link

@JDarDagran JDarDagran commented May 26, 2023

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-828206: Passwords containing only [ or ] RFC 1738 non-compliant #415

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

Adds quoting for [ and ].

I have read the CLA Document and I hereby sign the CLA

Signed-off-by: Jakub Dardzinski <[email protected]>
@github-actions
Copy link

github-actions bot commented May 26, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@JDarDagran
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@JDarDagran
Copy link
Author

recheck

@JDarDagran
Copy link
Author

Could someone please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-828206: Passwords containing only [ or ] RFC 1738 non-compliant
1 participant