-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connector version in RECORD_METADATA #766
Open
cchandurkar
wants to merge
7
commits into
snowflakedb:master
Choose a base branch
from
cchandurkar:version-in-metadata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
09c0bd6
Add connector version to RECORD_METADATA
cchandurkar f345bfa
Rename metadata SF connector version config
cchandurkar 81b39c8
Set SNOWFLAKE_METADATA_SF_CONNECTOR_VERSION_DEFAULT to false
cchandurkar 055bf1b
Format
cchandurkar 1270dc6
Fix test
cchandurkar 41967cb
flip the versionFlag to true
cchandurkar a2209be
Test version config value to be explicitly True
cchandurkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
import java.nio.file.Files; | ||
import java.nio.file.Paths; | ||
import java.util.HashMap; | ||
import net.snowflake.client.jdbc.internal.fasterxml.jackson.core.JsonProcessingException; | ||
import net.snowflake.client.jdbc.internal.fasterxml.jackson.databind.JsonNode; | ||
import net.snowflake.client.jdbc.internal.fasterxml.jackson.databind.ObjectMapper; | ||
import org.apache.kafka.common.record.TimestampType; | ||
|
@@ -38,6 +39,12 @@ public class MetaColumnTest { | |
put(SnowflakeSinkConnectorConfig.SNOWFLAKE_METADATA_TOPIC, "false"); | ||
} | ||
}; | ||
private HashMap<String, String> versionConfig = | ||
new HashMap<String, String>() { | ||
{ | ||
put(SnowflakeSinkConnectorConfig.SNOWFLAKE_METADATA_SF_CONNECTOR_VERSION, "false"); | ||
} | ||
}; | ||
private HashMap<String, String> offsetAndPartitionConfig = | ||
new HashMap<String, String>() { | ||
{ | ||
|
@@ -113,6 +120,18 @@ public void testConfig() throws IOException { | |
assert result.get(META).has(RecordService.OFFSET); | ||
assert result.get(META).has(RecordService.PARTITION); | ||
assert result.get(META).has(record.timestampType().name); | ||
assert !result.get(META).has(RecordService.SF_CONNECTOR_VERSION); | ||
|
||
// test metadata configuration -- add version | ||
metadataConfig = new SnowflakeMetadataConfig(versionConfig); | ||
service.setMetadataConfig(metadataConfig); | ||
result = mapper.readTree(service.getProcessedRecordForSnowpipe(record)); | ||
assert result.has(META); | ||
assert !result.get(META).has(RecordService.SF_CONNECTOR_VERSION); | ||
assert result.get(META).has(RecordService.OFFSET); | ||
assert result.get(META).has(RecordService.PARTITION); | ||
assert result.get(META).has(record.timestampType().name); | ||
assert result.get(META).has(RecordService.TOPIC); | ||
|
||
// test metadata configuration -- remove offset and partition | ||
metadataConfig = new SnowflakeMetadataConfig(offsetAndPartitionConfig); | ||
|
@@ -121,6 +140,7 @@ public void testConfig() throws IOException { | |
assert result.has(META); | ||
assert !result.get(META).has(RecordService.OFFSET); | ||
assert !result.get(META).has(RecordService.PARTITION); | ||
assert !result.get(META).has(RecordService.SF_CONNECTOR_VERSION); | ||
assert result.get(META).has(record.timestampType().name); | ||
assert result.get(META).has(RecordService.TOPIC); | ||
|
||
|
@@ -130,6 +150,7 @@ public void testConfig() throws IOException { | |
result = mapper.readTree(service.getProcessedRecordForSnowpipe(record)); | ||
assert result.has(META); | ||
assert !result.get(META).has(record.timestampType().name); | ||
assert !result.get(META).has(RecordService.SF_CONNECTOR_VERSION); | ||
assert result.get(META).has(RecordService.TOPIC); | ||
assert result.get(META).has(RecordService.OFFSET); | ||
assert result.get(META).has(RecordService.PARTITION); | ||
|
@@ -143,6 +164,42 @@ public void testConfig() throws IOException { | |
System.out.println("Config test success"); | ||
} | ||
|
||
@Test | ||
public void testSfConnectorVersion() throws JsonProcessingException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this test is failing |
||
|
||
SnowflakeConverter converter = new SnowflakeJsonConverter(); | ||
RecordService service = new RecordService(); | ||
SchemaAndValue input = | ||
converter.toConnectData( | ||
topic, ("{\"name\":\"test" + "\"}").getBytes(StandardCharsets.UTF_8)); | ||
long timestamp = System.currentTimeMillis(); | ||
|
||
SinkRecord record = | ||
new SinkRecord( | ||
topic, | ||
partition, | ||
Schema.STRING_SCHEMA, | ||
"test", | ||
input.schema(), | ||
input.value(), | ||
0, | ||
timestamp, | ||
TimestampType.CREATE_TIME); | ||
|
||
SnowflakeMetadataConfig metadataConfig = new SnowflakeMetadataConfig(topicConfig); | ||
service.setMetadataConfig(metadataConfig); | ||
|
||
metadataConfig = new SnowflakeMetadataConfig(versionConfig); | ||
service.setMetadataConfig(metadataConfig); | ||
JsonNode result = mapper.readTree(service.getProcessedRecordForSnowpipe(record)); | ||
assert result.has(META); | ||
assert result.get(META).has(RecordService.SF_CONNECTOR_VERSION); | ||
assert result.get(META).has(RecordService.OFFSET); | ||
assert result.get(META).has(RecordService.PARTITION); | ||
assert result.get(META).has(record.timestampType().name); | ||
assert result.get(META).has(RecordService.TOPIC); | ||
} | ||
|
||
@Test | ||
public void testTimeStamp() throws IOException { | ||
SnowflakeConverter converter = new SnowflakeJsonConverter(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -264,7 +264,10 @@ public void testSchematizationArrayOfObject() throws JsonProcessingException { | |
service.setEnableSchematization(true); | ||
String value = | ||
"{\"players\":[{\"name\":\"John Doe\",\"age\":30},{\"name\":\"Jane Doe\",\"age\":30}]}"; | ||
byte[] valueContents = (value).getBytes(StandardCharsets.UTF_8); | ||
String value2 = | ||
"{\"cricket\":{\"team\":{\"MI\":{\"players\":[{\"name\":\"John" | ||
+ " Doe\",\"age\":30},{\"name\":\"Jane Doe\",\"age\":30}]}}}}"; | ||
byte[] valueContents = (value2).getBytes(StandardCharsets.UTF_8); | ||
Comment on lines
+267
to
+270
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you need this? |
||
SchemaAndValue sv = jsonConverter.toConnectData(topic, valueContents); | ||
|
||
SinkRecord record = | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set this to true only when SNOWFLAKE_METADATA_SF_CONNECTOR_VERSION is true right? default is false now!