SNOW-1859651 Salt prefix for files mapped from different topics #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-wtrefon
approved these changes
Dec 20, 2024
| FileNameUtils.filePrefix(conn.getConnectorName(), tableName, topicName, partition); | ||
| } else { | ||
| this.prefix = FileNameUtils.filePrefix(conn.getConnectorName(), tableName, "", partition); | ||
| FileNameUtils.filePrefix(conn.getConnectorName(), tableName, topicForPrefix, partition); |
There was a problem hiding this comment.
so, if i read this correctly - we will not generate the salted prefix for all cases but only for a subset of them, right?
why not enable this by default for all?
There was a problem hiding this comment.
Correct. There are three benefits I can think of when topic2table.map is not used for particular topic:
- no chances of regression
- no leftover files just because the connector has been updated
- easier to identify partition numbers
sfc-gh-gjachimko
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1859651
Given two topics that are setup to be ingested to a single table using Snowpipe ingestion, each of the topics has an assigned cleaner for deleting already ingested files. This change prevents these cleaners from incorrectly cleaning files from the topic that should be handled by the other cleaner.
Any topic that is mapped by the
topic2table.mapshould have filename prefix salted with the topic as it is otherwise complicated (and unnecessary) to determine which other topic can have a clash on cleaning filenames.Supersedes: #1030
Pre-review checklist
snowflake.snowpipe.stageFileNameExtensionEnabled.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected