Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1831191 measure time of the schema evolution #1018

Closed
wants to merge 1 commit into from
Closed

SNOW-1831191 measure time of the schema evolution #1018

wants to merge 1 commit into from
+145 −5

Conversation

sfc-gh-bzabek
Copy link
Contributor

@sfc-gh-bzabek sfc-gh-bzabek commented Dec 4, 2024 •
edited
Loading

Overview

SNOW-1831191

Results:
https://docs.google.com/spreadsheets/d/1QEZjQINHxxU4FUXgiClgp5b-BSAxAA239e0r1jsptho/edit?gid=0#gid=0

We consider if it's worth merging.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

sfc-gh-mbobowski
sfc-gh-mbobowski reviewed Dec 5, 2024
View reviewed changes
...a/com/snowflake/kafka/connector/streaming/iceberg/IcebergSchemaEvolutionPerformanceTest.java

private String toValidNestedPayloadJson(int depth, StringJoiner joiner) {
StringBuilder sb = new StringBuilder();
sb.append("{");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart approach!

@sfc-gh-bzabek
Copy link
Contributor Author

No need to merge this changes. It was used for one off test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bzabek @sfc-gh-mbobowski