Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1728000 Iceberg e2e tests #1002

Merged
merged 1 commit into from
Nov 20, 2024
Merged

SNOW-1728000 Iceberg e2e tests #1002

merged 1 commit into from
Nov 20, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Nov 18, 2024 •
edited
Loading

Overview

SNOW-1728000

Tests pass on local environment using latest fixes from ingest-sdk that will be released in 3.0.1.

As always there is a huuuuge space for improvements but I think I made e2e tests code slightly better with this change.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski force-pushed the mbobowski-SNOW-1728000 branch 7 times, most recently from d350401 to 758962c Compare November 19, 2024 13:48
@sfc-gh-mbobowski sfc-gh-mbobowski changed the title [WIP] SNOW-1728000 Iceberg e2e tests SNOW-1728000 Iceberg e2e tests Nov 19, 2024
@sfc-gh-mbobowski sfc-gh-mbobowski marked this pull request as ready for review November 19, 2024 13:57
@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner November 19, 2024 13:57
sfc-gh-achyzy
sfc-gh-achyzy approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-achyzy sfc-gh-achyzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit d969e97 into master Nov 20, 2024
48 of 54 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1728000 branch November 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-achyzy sfc-gh-achyzy sfc-gh-achyzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mbobowski @sfc-gh-achyzy