Skip to content

Commit

Permalink
NO_SNOW Update Snowflake JDBC to 3.20.0 (#1000)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-xhuang authored Nov 20, 2024
1 parent e4a7e96 commit dfa33de
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-jdbc</artifactId>
<version>3.18.0</version>
<version>3.20.0</version>
</dependency>

<!-- Ingest SDK for copy staged file into snowflake table -->
Expand Down
2 changes: 1 addition & 1 deletion pom_confluent.xml
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@
<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-jdbc</artifactId>
<version>3.18.0</version>
<version>3.20.0</version>
</dependency>

<dependency>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
package com.snowflake.kafka.connector;

import static com.snowflake.kafka.connector.SnowflakeSinkConnectorConfig.BUFFER_FLUSH_TIME_SEC;
import static com.snowflake.kafka.connector.SnowflakeSinkConnectorConfig.INGESTION_METHOD_OPT;
import static com.snowflake.kafka.connector.SnowflakeSinkConnectorConfig.NAME;
import static com.snowflake.kafka.connector.SnowflakeSinkConnectorConfig.SNOWPIPE_STREAMING_CLOSE_CHANNELS_IN_PARALLEL;
import static com.snowflake.kafka.connector.SnowflakeSinkConnectorConfig.*;
import static org.apache.kafka.connect.runtime.ConnectorConfig.CONNECTOR_CLASS_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.KEY_CONVERTER_CLASS_CONFIG;
import static org.apache.kafka.connect.runtime.ConnectorConfig.TASKS_MAX_CONFIG;
Expand Down Expand Up @@ -74,7 +71,8 @@ protected final Map<String, String> defaultProperties(String topicName, String c
config.put(TOPICS_CONFIG, topicName);
config.put(INGESTION_METHOD_OPT, IngestionMethodConfig.SNOWPIPE_STREAMING.toString());
config.put(Utils.SF_ROLE, "testrole_kafka");
config.put(BUFFER_FLUSH_TIME_SEC, "1");
config.put(SNOWPIPE_STREAMING_MAX_CLIENT_LAG, "1");
config.put(SNOWPIPE_STREAMING_ENABLE_SINGLE_BUFFER, "true");
config.put(TASKS_MAX_CONFIG, TASK_NUMBER.toString());
config.put(SNOWPIPE_STREAMING_CLOSE_CHANNELS_IN_PARALLEL, "true");
config.put(KEY_CONVERTER_CLASS_CONFIG, StringConverter.class.getName());
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/snowflake/kafka/connector/SmtIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ void testIfSmtReturningNullsIngestDataCorrectly(String behaviorOnNull, int expec

// then
await()
.timeout(Duration.ofSeconds(60))
.timeout(Duration.ofSeconds(30))
.pollInterval(Duration.ofSeconds(1))
.untilAsserted(
() -> {
assertThat(fakeStreamingClientHandler.ingestedRows()).hasSize(expectedRecordNumber);
Expand Down

0 comments on commit dfa33de

Please sign in to comment.