Fix after rebase

snowflakedb · Dec 5, 2024 · cff0fac · cff0fac
1 parent 6ba0bf5
commit cff0fac
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/.../com/snowflake/kafka/connector/streaming/iceberg/IcebergIngestionNoSchemaEvolutionIT.java b/.../com/snowflake/kafka/connector/streaming/iceberg/IcebergIngestionNoSchemaEvolutionIT.java
@@ -16,7 +16,6 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import org.apache.kafka.connect.sink.SinkRecord;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
@@ -99,7 +98,6 @@ void shouldInsertRecords(String description, String message, boolean withSchema)
   }
 
   @Test
-  @Disabled
   void shouldSendValueWithWrongTypeToDLQ() throws Exception {
     SinkRecord wrongValueRecord1 =
         createKafkaRecord(complexJsonPayloadWithWrongValueTypeExample, 0, false);

diff --git a/...va/com/snowflake/kafka/connector/streaming/iceberg/IcebergIngestionSchemaEvolutionIT.java b/...va/com/snowflake/kafka/connector/streaming/iceberg/IcebergIngestionSchemaEvolutionIT.java
@@ -258,17 +258,15 @@ public void testComplexRecordEvolution() throws Exception {
           new DescribeTableRow("APPROVAL", "BOOLEAN"),
           new DescribeTableRow("ARRAY1", "ARRAY(NUMBER(19,0))"),
           new DescribeTableRow("ARRAY2", "ARRAY(VARCHAR(16777216))"),
-          new DescribeTableRow("ARRAY3", "ARRAY(VARCHAR(16777216))"),
-          // "array4" : null -> VARCHAR(16777216
+          new DescribeTableRow("ARRAY3", "ARRAY(BOOLEAN)"),
           new DescribeTableRow("ARRAY4", "VARCHAR(16777216)"),
           new DescribeTableRow("ARRAY5", "ARRAY(ARRAY(NUMBER(19,0)))"),
           new DescribeTableRow(
               "NESTEDRECORD",
               "OBJECT(id_int8 NUMBER(19,0), id_int16 NUMBER(19,0), rating_float32 FLOAT,"
                   + " rating_float64 FLOAT, approval BOOLEAN, id_int32 NUMBER(19,0), description"
                   + " VARCHAR(16777216), id_int64 NUMBER(19,0))"),
-          // "nestedRecord2": null -> VARCHAR(16777216)
-          new DescribeTableRow("NESTEDRECORD2", "VARCHAR(16777216)"),
+          new DescribeTableRow("NESTEDRECORD2", RECORD_METADATA_TYPE),
         };
     assertThat(columns).containsExactlyInAnyOrder(expectedSchema);
   }
@@ -499,7 +497,6 @@ void shouldAppendCommentTest() throws Exception {
 
   @ParameterizedTest(name = "{0}")
   @MethodSource("nullOrEmptyValueShouldBeSentToDLQOnlyWhenNoSchema_dataSource")
-  @Disabled
   void nullOrEmptyValueShouldBeSentToDLQOnlyWhenNoSchema(
       String description, String jsonWithNullOrEmpty, String jsonWithFullData) throws Exception {
     // given
@@ -526,7 +523,6 @@ void nullOrEmptyValueShouldBeSentToDLQOnlyWhenNoSchema(
 
   @ParameterizedTest(name = "{0}")
   @MethodSource("wrongTypeValueMessages_dataSource")
-  @Disabled
   void shouldSendValueWithWrongTypeToDLQ(
       String description, String correctValueJson, String wrongValueJson) throws Exception {
     // when