Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1821504: [JDBC] Initialal OCSP deprecation plan steps #2008

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

SNOW-1821504: [JDBC] Initialal OCSP deprecation plan steps #2008

wants to merge 27 commits into from
+192 −15

Conversation

sfc-gh-ext-simba-vb
Copy link
Collaborator

Overview

SNOW-1821504

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb marked this pull request as ready for review December 17, 2024 22:45
@sfc-gh-ext-simba-vb sfc-gh-ext-simba-vb requested a review from a team as a code owner December 17, 2024 22:45
@sfc-gh-ext-simba-vb
Copy link
Collaborator Author

Hi @sfc-gh-pfus, code review comments implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf left review comments

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus left review comments

@sfc-gh-dszmolka sfc-gh-dszmolka sfc-gh-dszmolka left review comments

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-ext-simba-vb @sfc-gh-dszmolka @sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-pfus @sfc-gh-ext-simba-jf