Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1825471: PAT authentication support #1995

Merged
merged 1 commit into from
Dec 12, 2024
Merged

SNOW-1825471: PAT authentication support #1995

merged 1 commit into from
Dec 12, 2024

Conversation

sfc-gh-dheyman
Copy link
Contributor

@sfc-gh-dheyman sfc-gh-dheyman commented Dec 10, 2024 •
edited
Loading

Overview

SNOW-1825471

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner December 10, 2024 15:08
sfc-gh-pfus
sfc-gh-pfus approved these changes Dec 12, 2024
View reviewed changes
src/main/java/net/snowflake/client/core/SFLoginInput.java
@@ -249,8 +249,7 @@ public int getSocketTimeoutInMillis() {
return (int) socketTimeout.toMillis();
}

@SnowflakeJdbcInternalApi
public SFLoginInput setSocketTimeout(Duration socketTimeout) {
SFLoginInput setSocketTimeout(Duration socketTimeout) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine to reduce the visibility here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reduce on internal methods

@sfc-gh-dheyman sfc-gh-dheyman merged commit a45009a into oauth-code-flow Dec 12, 2024
4 of 7 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the pat-token-support branch December 12, 2024 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz Awaiting requested review from sfc-gh-dprzybysz

@sfc-gh-mhofman sfc-gh-mhofman Awaiting requested review from sfc-gh-mhofman

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski Awaiting requested review from sfc-gh-jszczerbinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dheyman @sfc-gh-dprzybysz @sfc-gh-pmotacki @sfc-gh-pfus