Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1848734: Fix for structured types as strings performance problems #1991

Merged
merged 9 commits into from
Dec 10, 2024
Merged

SNOW-1848734: Fix for structured types as strings performance problems #1991

merged 9 commits into from
Dec 10, 2024

Conversation

sfc-gh-pmotacki
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki commented Dec 9, 2024 •
edited by sfc-gh-dprzybysz
Loading

Overview

SNOW-1848734

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner December 9, 2024 20:37
@sfc-gh-pmotacki sfc-gh-pmotacki changed the title SNOW-1689931 Adding flag to skip token file permission verification Fix for structured types as strings Dec 10, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Fix for structured types as strings SNOW-1848734 - Fix for structured types as strings Dec 10, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1848734 - Fix for structured types as strings SNOW-1848734: Fix for structured types as strings performance problems Dec 10, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit e793e61 into master Dec 10, 2024
139 of 142 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the fix_structured_type_string_arrow branch December 10, 2024 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz @sfc-gh-mkubik