Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1825471: Port and remove snowflake-common auth related codebase #1976

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

sfc-gh-dheyman
Copy link
Contributor

@sfc-gh-dheyman sfc-gh-dheyman commented Nov 28, 2024

Overview

SNOW-1825471

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner November 28, 2024 22:13
@sfc-gh-dheyman sfc-gh-dheyman force-pushed the SNOW-1825471-snowflake-common-auth-removal branch 6 times, most recently from 6d262e1 to af2f8c3 Compare November 29, 2024 09:58
@sfc-gh-dheyman sfc-gh-dheyman force-pushed the SNOW-1825471-snowflake-common-auth-removal branch 2 times, most recently from b4322f3 to 43b46f3 Compare November 29, 2024 12:11
@sfc-gh-dheyman sfc-gh-dheyman force-pushed the SNOW-1825471-snowflake-common-auth-removal branch from 43b46f3 to ee7ad70 Compare November 29, 2024 12:15
@sfc-gh-dheyman sfc-gh-dheyman merged commit c62c5e4 into master Nov 29, 2024
139 of 142 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-1825471-snowflake-common-auth-removal branch November 29, 2024 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants