Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1689931 Adding flag to skip token file permission verification #1959

Merged

Conversation

sfc-gh-pmotacki
Copy link
Contributor

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner November 7, 2024 12:04
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1689931-token-file-permissions-verification branch from 07a3201 to 3244400 Compare November 7, 2024 12:31
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1689931-token-file-permissions-verification branch from 4bad7d1 to 147d02e Compare November 25, 2024 05:47
Copy link
Contributor

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at suggestions but other than this looks good

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 7fd70cd into master Nov 26, 2024
141 of 142 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1689931-token-file-permissions-verification branch November 26, 2024 09:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants