-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1689931 Adding flag to skip token file permission verification #1959
Merged
sfc-gh-pmotacki
merged 8 commits into
master
from
SNOW-1689931-token-file-permissions-verification
Nov 26, 2024
Merged
SNOW-1689931 Adding flag to skip token file permission verification #1959
sfc-gh-pmotacki
merged 8 commits into
master
from
SNOW-1689931-token-file-permissions-verification
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pmotacki
force-pushed
the
SNOW-1689931-token-file-permissions-verification
branch
from
November 7, 2024 12:31
07a3201
to
3244400
Compare
sfc-gh-dprzybysz
requested changes
Nov 8, 2024
sfc-gh-dprzybysz
approved these changes
Nov 12, 2024
sfc-gh-pmotacki
force-pushed
the
SNOW-1689931-token-file-permissions-verification
branch
from
November 25, 2024 05:47
4bad7d1
to
147d02e
Compare
sfc-gh-pfus
reviewed
Nov 25, 2024
src/main/java/net/snowflake/client/config/SFConnectionConfigParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/config/SFConnectionConfigParser.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/config/SFConnectionConfigParserTest.java
Show resolved
Hide resolved
sfc-gh-pfus
approved these changes
Nov 25, 2024
src/test/java/net/snowflake/client/config/SFConnectionConfigParserTest.java
Outdated
Show resolved
Hide resolved
sfc-gh-mhofman
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at suggestions but other than this looks good
sfc-gh-pmotacki
deleted the
SNOW-1689931-token-file-permissions-verification
branch
November 26, 2024 09:25
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.