Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1016469: Adding missing comments to public methods #1928

Merged
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a936500
Adding missing comments to public methods part 1
sfc-gh-ext-simba-jf Oct 17, 2024
bdf5c36
Add missing comments part 2
sfc-gh-ext-simba-jf Oct 17, 2024
221e202
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 17, 2024
6efb936
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 23, 2024
a261619
Adding missing javadocs part 3
sfc-gh-ext-simba-jf Oct 23, 2024
b5800ba
Add missing javadocs part 4
sfc-gh-ext-simba-jf Oct 23, 2024
a91a006
java doc update part 5
sfc-gh-ext-simba-jf Oct 23, 2024
3e0678b
java doc update part 6
sfc-gh-ext-simba-jf Oct 23, 2024
34c6737
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 23, 2024
47632ba
Added more javadocs part 7
sfc-gh-ext-simba-jf Oct 24, 2024
9123e30
java doc update part 8
sfc-gh-ext-simba-jf Oct 24, 2024
d1876df
java doc updates part 9
sfc-gh-ext-simba-jf Oct 24, 2024
d6b6ee8
Merge branch 'SNOW-1016469-Update-Javadocs-With-missing-comments' of …
sfc-gh-ext-simba-jf Oct 24, 2024
ce70f98
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 24, 2024
cd11018
Fix missing javadocs part 10
sfc-gh-ext-simba-jf Oct 24, 2024
72bd1d1
Merge branch 'SNOW-1016469-Update-Javadocs-With-missing-comments' of …
sfc-gh-ext-simba-jf Oct 24, 2024
11135b9
fix missing javadoc comments part 11
sfc-gh-ext-simba-jf Oct 24, 2024
4f61f1b
javadoc update part 12
sfc-gh-ext-simba-jf Oct 24, 2024
f90829f
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 25, 2024
5d0394c
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 28, 2024
49914b0
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 31, 2024
bc15a0d
Code review changes
sfc-gh-ext-simba-jf Oct 31, 2024
c739f57
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 31, 2024
92f5897
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Oct 31, 2024
a88f694
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Nov 4, 2024
8eb9e7c
code review changes
sfc-gh-ext-simba-jf Nov 5, 2024
38900bf
Merge branch 'SNOW-1016469-Update-Javadocs-With-missing-comments' of …
sfc-gh-ext-simba-jf Nov 6, 2024
5d53094
Added more details for certain getters and setters
sfc-gh-ext-simba-jf Nov 6, 2024
eb4969b
Merge branch 'master' into SNOW-1016469-Update-Javadocs-With-missing-…
sfc-gh-ext-simba-jf Nov 6, 2024
7b61fac
triggering jenkins test
sfc-gh-ext-simba-jf Nov 6, 2024
284806e
Merge branch 'SNOW-1016469-Update-Javadocs-With-missing-comments' of …
sfc-gh-ext-simba-jf Nov 6, 2024
5e99b2c
code review changes
sfc-gh-ext-simba-jf Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ private static QueryContextElement deserializeQueryContextElementDTO(
* Serialize the QueryContext cache to a QueryContextDTO object, which can be serialized to JSON
* automatically later.
*
* @return QueryContextDTO
* @return QueryContextDTO {@link QueryContextDTO}
*/
public QueryContextDTO serializeQueryContextDTO() {
synchronized (this) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/snowflake/client/core/ResultUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static Object effectiveParamValue(Map<String, Object> parameters, String
* @param id id
* @param param timestamp output format param
* @param defaultFormat default format
* @return SnowflakeDateTimeFormat
* @return SnowflakeDateTimeFormat {@link SnowflakeDateTimeFormat}
*/
public static SnowflakeDateTimeFormat specializedFormatter(
Map<String, Object> parameters, String id, String param, String defaultFormat) {
Expand Down
38 changes: 28 additions & 10 deletions src/main/java/net/snowflake/client/core/SFBaseSession.java
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,11 @@ public void setDatabaseMinorVersion(int databaseMinorVersion) {
}

/**
* Get if prepared statement logging is enabled
* Gets the value of CLIENT_ENABLE_LOG_INFO_STATEMENT_PARAMETERS if one has been set. False by
* default.
*
* @see <a
* href="https://docs.snowflake.com/en/sql-reference/parameters#client-enable-log-info-statement-parameters">CLIENT_ENABLE_LOG_INFO_STATEMENT_PARAMETERS</a>
* @return true if enabled
*/
public boolean getPreparedStatementLogging() {
Expand All @@ -301,6 +304,7 @@ public boolean getPreparedStatementLogging() {
/**
* Set prepared statement logging
*
* @see SFBaseSession#getPreparedStatementLogging()
* @param value boolean
*/
public void setPreparedStatementLogging(boolean value) {
Expand Down Expand Up @@ -328,7 +332,9 @@ public void setInjectFileUploadFailure(String fileToFail) {
/**
* Get timestamp mapped type
*
* @return SnowflakeType
* @see <a
* href="https://docs.snowflake.com/en/sql-reference/parameters#client-timestamp-type-mapping">CLIENT_TIMESTAMP_TYPE_MAPPING</a>
* @return SnowflakeType {@link SnowflakeType}
*/
public SnowflakeType getTimestampMappedType() {
return timestampMappedType;
Expand All @@ -337,6 +343,7 @@ public SnowflakeType getTimestampMappedType() {
/**
* Set the timestamp mapped type
*
* @see SFBaseSession#getTimestampMappedType()
* @param timestampMappedType SnowflakeType
*/
public void setTimestampMappedType(SnowflakeType timestampMappedType) {
Expand All @@ -346,6 +353,7 @@ public void setTimestampMappedType(SnowflakeType timestampMappedType) {
/**
* Get if result column is case-insensitive
*
* @see SFBaseSession#setResultColumnCaseInsensitive(boolean)
* @return true if result column is case-insensitive
*/
public boolean isResultColumnCaseInsensitive() {
Expand All @@ -355,6 +363,8 @@ public boolean isResultColumnCaseInsensitive() {
/**
* Set if result column is case-insensitive
*
* @see <a
* href="https://docs.snowflake.com/en/sql-reference/parameters#client-result-column-case-insensitive">CLIENT_RESULT_COLUMN_CASE_INSENSITIVE</a>
* @param resultColumnCaseInsensitive boolean
*/
public void setResultColumnCaseInsensitive(boolean resultColumnCaseInsensitive) {
Expand All @@ -364,6 +374,8 @@ public void setResultColumnCaseInsensitive(boolean resultColumnCaseInsensitive)
/**
* Check if we want to treat decimal as int JDBC types
*
* @see <a
* href="https://docs.snowflake.com/en/sql-reference/parameters#jdbc-treat-decimal-as-int">JDBC_TREAT_DECIMAL_AS_INT</a>
* @return true if decimal is treated as int
*/
public boolean isJdbcTreatDecimalAsInt() {
Expand All @@ -373,6 +385,7 @@ public boolean isJdbcTreatDecimalAsInt() {
/**
* Set if decimal should be treated as int type
*
* @see SFBaseSession#isJdbcTreatDecimalAsInt()
* @param jdbcTreatDecimalAsInt boolean
*/
public void setJdbcTreatDecimalAsInt(boolean jdbcTreatDecimalAsInt) {
Expand Down Expand Up @@ -696,7 +709,7 @@ public void unsetInvalidProxyHostAndPort() {
/**
* Get OCSP mode
*
* @return OSCPMode
* @return OCSPMode {@link OCSPMode}
*/
public OCSPMode getOCSPMode() {
OCSPMode ret;
Expand Down Expand Up @@ -799,7 +812,7 @@ public void setMetadataRequestUseConnectionCtx(boolean enabled) {
/**
* Get injected delay
*
* @return AtomicInteger
* @return AtomicInteger {@link AtomicInteger}
*/
AtomicInteger getInjectedDelay() {
return _injectedDelay;
Expand Down Expand Up @@ -876,17 +889,22 @@ public int getHeartbeatFrequency() {
}

/**
* Get autocommit
* autoCommit field specifies whether autocommit is enabled for the session. Autocommit determines
* whether a DML statement, when executed without an active transaction, is automatically
* committed after the statement successfully completes. default: true
*
* @return true if autocommit is set
* @see <a
* href="https://docs.snowflake.com/en/sql-reference/transactions#label-txn-autocommit">Transactions/Autocommit</a>
* @return a boolean value of autocommit field
*/
public boolean getAutoCommit() {
return autoCommit.get();
}

/**
* Set autocommit
* Sets value of autoCommit field
*
* @see SFBaseSession#getAutoCommit()
* @param autoCommit boolean
*/
public void setAutoCommit(boolean autoCommit) {
Expand All @@ -912,7 +930,7 @@ public void setFormatDateWithTimezone(boolean formatDateWithTimezone) {
}

/**
* Get if session timezone should be used
* Get if session timezone should be used.
*
* @return true if using session timezone
*/
Expand Down Expand Up @@ -1242,7 +1260,7 @@ public void clearSqlWarnings() {
/**
* Get the SFConnectionHandler
*
* @return SFConnectionHandler
* @return SFConnectionHandler {@link SFConnectionHandler}
*/
public SFConnectionHandler getSfConnectionHandler() {
return sfConnectionHandler;
Expand All @@ -1266,7 +1284,7 @@ public SFConnectionHandler getSfConnectionHandler() {
public abstract int getMaxHttpRetries();

/**
* @return SnowflakeConnectString
* @return SnowflakeConnectString {@link SnowflakeConnectString}
*/
public abstract SnowflakeConnectString getSnowflakeConnectionString();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public static boolean isFileTransfer(String sql) {
* Retrieves the current result as a ResultSet, if any. This is invoked by SnowflakeStatement and
* should return an SFBaseResultSet, which is then wrapped in a SnowflakeResultSet.
*
* @return SFBaseResultSet
* @return SFBaseResultSet {@link SFBaseResultSet}
sfc-gh-dprzybysz marked this conversation as resolved.
Show resolved Hide resolved
*/
public abstract SFBaseResultSet getResultSet();

Expand Down
Loading