-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1693588 Upgrade to JUnit5 #1909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/net/snowflake/client/annotations/DontRunOnGithubActions.java
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/structuredtypes/ResultSetStructuredTypesLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/providers/FormatProvider.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/providers/SimpleFormatProvider.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/test/java/net/snowflake/client/jdbc/ClientMemoryLimitParallelIT.java # src/test/java/net/snowflake/client/jdbc/ConnectionIT.java # src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java # src/test/java/net/snowflake/client/jdbc/DatabaseMetaDataIT.java # src/test/java/net/snowflake/client/jdbc/DatabaseMetaDataLatestIT.java # src/test/java/net/snowflake/client/jdbc/DatabaseMetaDataResultsetIT.java # src/test/java/net/snowflake/client/jdbc/MultiStatementLatestIT.java # src/test/java/net/snowflake/client/jdbc/OpenGroupCLIFuncIT.java # src/test/java/net/snowflake/client/jdbc/PreparedMultiStmtArrowIT.java # src/test/java/net/snowflake/client/jdbc/PreparedMultiStmtIT.java # src/test/java/net/snowflake/client/jdbc/SnowflakeDriverLatestIT.java # src/test/java/net/snowflake/client/jdbc/SnowflakeUtilTest.java # src/test/java/net/snowflake/client/jdbc/StreamLatestIT.java
# Conflicts: # src/test/java/net/snowflake/client/jdbc/FileUploaderPrep.java # src/test/java/net/snowflake/client/jdbc/FileUploaderSessionlessTest.java
sfc-gh-pfus
reviewed
Nov 26, 2024
sfc-gh-pfus
approved these changes
Nov 27, 2024
# Conflicts: # src/test/java/net/snowflake/client/config/SFConnectionConfigParserTest.java
sfc-gh-dprzybysz
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1693588 upgraded all tests to junit5. There are a lot of changes, but most are of following types:
@Test
annotation, Assumptions, Assertions)@Before
to@BeforeEach
,@BeforeClass
to@BeforeAll
etc.)@BeforeClass
annotations could not be translated to junit5, as the fields they depend on no longer exist. As a result, in those cases relevant functions are now called at the beginning of each test. (Could be remedied later I believe)@Rule
to@TempDir
)@TempDir
on windows)@Category
annotations to junit5@Tag
assertThrows
instead.Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX: