Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1668681: Run JDBC unit tests on AIX #1900

Merged
merged 4 commits into from
Sep 24, 2024
Merged

SNOW-1668681: Run JDBC unit tests on AIX #1900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44ff5f2
Disable all converter tests
sfc-gh-jszczerbinski Sep 19, 2024
6b20da7
Add AIX Unit tests to Jenkinsfile
sfc-gh-jszczerbinski Sep 23, 2024
bedf2ce
Fix parameter passing
sfc-gh-jszczerbinski Sep 23, 2024
35f39e6
Fix formatting
sfc-gh-jszczerbinski Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ timestamps {
}.collectEntries { jobDefinition ->
return [(jobDefinition.runName): { build job: jobDefinition.jobToRun, parameters: jobDefinition.params }]
}

jobDefinitions.put('JDBC-AIX-Unit', { build job: 'JDBC-AIX-UnitTests', parameters: [ string(name: 'BRANCH', value: scmInfo.GIT_BRANCH ) ] } )
stage('Test') {
parallel (jobDefinitions)
}
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/net/snowflake/client/core/arrow/BaseConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
*/
package net.snowflake.client.core.arrow;

import java.nio.ByteOrder;
import java.util.TimeZone;
import net.snowflake.client.core.DataConversionContext;
import net.snowflake.client.core.SFSession;
import net.snowflake.client.jdbc.ErrorCode;
import net.snowflake.common.core.SFBinaryFormat;
import net.snowflake.common.core.SnowflakeDateTimeFormat;
import org.junit.After;
import org.junit.Assume;
import org.junit.Before;

public class BaseConverterTest implements DataConversionContext {
private SnowflakeDateTimeFormat dateTimeFormat =
Expand All @@ -32,6 +35,13 @@ public void clearTimeZone() {
System.clearProperty("user.timezone");
}

@Before
public void assumeLittleEndian() {
Assume.assumeTrue(
"Arrow doesn't support cross endianness",
ByteOrder.nativeOrder().equals(ByteOrder.LITTLE_ENDIAN));
}

@Override
public SnowflakeDateTimeFormat getTimestampLTZFormatter() {
return timestampLTZFormat;
Expand Down
Loading