Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1636262: getDate triggers NPE with 3.18.0 (regression) #1877

Conversation

sfc-gh-jszczerbinski
Copy link
Contributor

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski commented Aug 27, 2024

Overview

SNOW-1636262

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title Use serializable config when session not present getDate triggers NPE with 3.18.0 (regression) Aug 28, 2024
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title getDate triggers NPE with 3.18.0 (regression) SNOW-1636262: getDate triggers NPE with 3.18.0 (regression) Aug 28, 2024
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski marked this pull request as ready for review August 29, 2024 06:43
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski requested a review from a team as a code owner August 29, 2024 06:43
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski merged commit 0b79dd9 into master Aug 29, 2024
140 of 142 checks passed
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski deleted the SNOW-1636262-get-date-triggers-npe-with-3-18-0-regression branch August 29, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants