Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init converters refactor #1873

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Init converters refactor #1873

merged 12 commits into from
Sep 2, 2024

Conversation

sfc-gh-astachowski
Copy link
Collaborator

@sfc-gh-astachowski sfc-gh-astachowski commented Aug 22, 2024 •
edited
Loading

Overview

Moved the logic for initialising converters to be public scope, so it can be easily reused in the future.

Also increased the version of japicmp to 0.17.3 to include a needed bugfix.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner August 22, 2024 07:11
@sfc-gh-mkubik sfc-gh-mkubik merged commit 107d370 into master Sep 2, 2024
142 checks passed
@sfc-gh-mkubik sfc-gh-mkubik deleted the init-converters-refactor branch September 2, 2024 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-astachowski @sfc-gh-pbulawa @sfc-gh-mkubik