Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1168512: continuing SNOW-1020043: expose timeouts (DEFAULT_CONNECTION_TIMEOUT and DEFAULT_HTTP_CLIENT_SOCKET_TIMEOUT) in JDBC as Connection string and/or datasource property #1865

Merged
merged 16 commits into from
Aug 28, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title implemented the connection timeout and socket timeout SNOW-1168512 Aug 7, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1168512 SNOW-864140: Check build/test instruction for libsnowflakeclient and make correction as needed Aug 13, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-864140: Check build/test instruction for libsnowflakeclient and make correction as needed SNOW-1168512: continuing SNOW-1020043: expose timeouts (DEFAULT_CONNECTION_TIMEOUT and DEFAULT_HTTP_CLIENT_SOCKET_TIMEOUT) in JDBC as Connection string and/or datasource property Aug 13, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review August 13, 2024 03:49
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner August 13, 2024 03:49
@sfc-gh-pbulawa sfc-gh-pbulawa self-requested a review August 13, 2024 06:56
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 714da2f into master Aug 28, 2024
139 of 140 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the SNOW-1168512v2 branch August 28, 2024 00:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants