-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1168512: continuing SNOW-1020043: expose timeouts (DEFAULT_CONNECTION_TIMEOUT and DEFAULT_HTTP_CLIENT_SOCKET_TIMEOUT) in JDBC as Connection string and/or datasource property #1865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-jy
changed the title
implemented the connection timeout and socket timeout
SNOW-1168512
Aug 7, 2024
sfc-gh-ext-simba-jy
requested review from
sfc-gh-pmotacki and
sfc-gh-snow-drivers-warsaw-dl
August 13, 2024 03:48
sfc-gh-ext-simba-jy
changed the title
SNOW-1168512
SNOW-864140: Check build/test instruction for libsnowflakeclient and make correction as needed
Aug 13, 2024
sfc-gh-ext-simba-jy
changed the title
SNOW-864140: Check build/test instruction for libsnowflakeclient and make correction as needed
SNOW-1168512: continuing SNOW-1020043: expose timeouts (DEFAULT_CONNECTION_TIMEOUT and DEFAULT_HTTP_CLIENT_SOCKET_TIMEOUT) in JDBC as Connection string and/or datasource property
Aug 13, 2024
sfc-gh-pbulawa
approved these changes
Aug 13, 2024
sfc-gh-mkubik
approved these changes
Aug 22, 2024
…lake-jdbc into SNOW-1168512v2
…lake-jdbc into SNOW-1168512v2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.