-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-732360: Allow connection caching to be disabled by user #1845
Merged
sfc-gh-pbulawa
merged 9 commits into
master
from
Snow-732360-Allow-Connection-Caching-to-be-Disabled
Aug 29, 2024
Merged
SNOW-732360: Allow connection caching to be disabled by user #1845
sfc-gh-pbulawa
merged 9 commits into
master
from
Snow-732360-Allow-Connection-Caching-to-be-Disabled
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default connection caching is allowed.
src/main/java/net/snowflake/client/jdbc/SnowflakeBasicDataSource.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/SnowflakeMFACacheTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/SessionUtilExternalBrowserTest.java
Outdated
Show resolved
Hide resolved
sfc-gh-pmotacki
approved these changes
Aug 28, 2024
sfc-gh-pbulawa
approved these changes
Aug 29, 2024
sfc-gh-pbulawa
changed the title
Allow connection caching to be disabled by user
SNOW-732360: Allow connection caching to be disabled by user
Aug 29, 2024
sfc-gh-pbulawa
deleted the
Snow-732360-Allow-Connection-Caching-to-be-Disabled
branch
August 29, 2024 10:42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-732360
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Added new connection parameters:
clientStoreTemporaryCredential -> default true
clientRequestMfaToken -> default true
To allow user to disable connection caching on windows and mac osx