Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1454054: Clarifymessage about excessive permission #1844

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sfc-gh-pmotacki
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki commented Jul 24, 2024

Overview

SNOW-1454054

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner July 24, 2024 12:42
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the clarifying_file_permission_log_message branch from da8f966 to 9017df4 Compare July 24, 2024 13:12
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1454054 - clarifying message about excessive permission SNOW-1454054: Clarifymessage about excessive permission Jul 25, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit b33b67e into master Jul 30, 2024
139 of 141 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the clarifying_file_permission_log_message branch July 30, 2024 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants