Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1452649 update dependency to httpclient library to support zstd #1783

Conversation

sfc-gh-dbouassida
Copy link
Contributor

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Copy link

github-actions bot commented Jun 6, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@@ -142,6 +144,23 @@ else if (context.getQrmk() != null) {
return response;
}

public static InputStream detectGzipAndGetStream(InputStream is) throws IOException {
try {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might even not need this, as the is comes wrapped in the correct decmpressor. this is handeled at the http client level.

@sfc-gh-dbouassida sfc-gh-dbouassida deleted the dbouassida-SNOW-1452649-experiment-with-different-compression-types branch June 24, 2024 07:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@sfc-gh-dbouassida sfc-gh-dbouassida restored the dbouassida-SNOW-1452649-experiment-with-different-compression-types branch August 15, 2024 17:35
@sfc-gh-dprzybysz
Copy link
Collaborator

Done in #1932

@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the dbouassida-SNOW-1452649-experiment-with-different-compression-types branch October 31, 2024 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants